Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selection undo #28281

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Conversation

zqyoung1
Copy link

@zqyoung1 zqyoung1 commented Apr 21, 2019

Properly resets text selection when an undo occurs
Fully fixes #14835

@zqyoung1 zqyoung1 changed the title Fix selection undo Fix selection undo #14835 Apr 21, 2019
@zqyoung1 zqyoung1 changed the title Fix selection undo #14835 Fix selection undo Apr 21, 2019
scene/gui/text_edit.cpp Outdated Show resolved Hide resolved
@YeldhamDev
Copy link
Member

@YeldhamDev
Copy link
Member

Weird, the clang check if failing because it sees a trailing whitespace, but there's none in the commit itself.

@zqyoung1
Copy link
Author

Yeah that's very odd. Do you have any suggestions for how to proceed?

@YeldhamDev
Copy link
Member

Try git commit --amend and --force push it again to trigger a new check, to see if this was just Travis being silly.

@YeldhamDev
Copy link
Member

Yep, the static check succeeded this time.

@akien-mga akien-mga added this to the 3.2 milestone Apr 23, 2019
@akien-mga akien-mga merged commit 6822ee3 into godotengine:master Apr 29, 2019
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selections are not stored in the text operations for Undo
3 participants